cmss13-devs / cmss13-devs/cmss13

Cancelling an ADD operation late enough destroys paper and simulation.

Open
#12,974 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

### Testmerges

N/A

### Round ID

_No response_

### Description of the bug

Cancelling an ADD operation (adding property from reference to target) right before the operation lets you pick recipe options causes the reference paper to be destroyed and the target not to produce a new simulation paper.

### What's the difference with what should have happened?

The operation should have cancelled cleanly and returned two usable papers.

### How do we reproduce this bug?

1. ADD a property from reference to target.
2. Wait until the machine is about to give you options for recipe ingredients.
3. Cancel.
...

### Issue Bingo

- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [ ] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the ADD operation and cancel it just before the machine presents recipe ingredient options. Trace the cancellation path for the reference and target papers; done means cancellation leaves both papers usable and does not create an unwanted simulation paper.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.