cmss13-devs / cmss13-devs/cmss13

deconstructing locker with mob inside deletes the mob

Open
#12,973 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

### Testmerges

#12824: 'Bundles Wound Overlay Updates' by fira at commit 6b48f2d5f1 #12537: 'Atlan Station - Groundmap' by oceany-a11y at commit 3fa25ce779 #12721: 'Assorted Sound Fixes' by fira at commit 8b5bf0b649 #12618: 'Vanguard Passive Shield no longer regenerates when UNCONSCIOUS or INCAPACITATED, FLOORED, updated strain description.' by Venuska1117 at commit 8aa3006d71 #12965: 'Fixes base rav permanent empower' by Nihisohel at commit 542efb3ebd #12627: 'Tyrargo Rift (2) - Various Alterations' by Steelpoint at commit dbc4496523 #12626: 'Refurbished Combat Information Centre (2) - USS Almayer' by Steelpoint at commit 86a9778d04

### Round ID

35952

### Description of the bug

person goes inside the locker, close the locker and deconstruct it, mob is deleted. should be what happened to warden toc on 35952

### What's the difference with what should have happened?

the deconstruct code should check if there's a mob inside what you're deconstructing, if so, move the mob out then deconstruct

### How do we reproduce this bug?

person goes inside the locker, close the locker and deconstruct it, mob is deleted

### Issue Bingo

- [ ] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by placing a mob inside a closed locker and deconstructing it, then trace the locker deconstruction code. Verify that a mob inside is moved out before the locker is deconstructed and is not deleted.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.