cmss13-devs / cmss13-devs/cmss13
Orders aren't faction checked
- Dominant language
- DM
- Stars
- 170
- Forks
- 940
- Avg merge
- 5d 16h
- Merged PRs (30d)
- 61
Description
### Testmerges
N/A
### Round ID
N/A
### Description of the bug
CLF Orders (Move, Focus, Hold) affect marines and vice versa.
### What's the difference with what should have happened?
The enemy shouldn't inspire you.
### How do we reproduce this bug?
1. Shout order at marines with CLF in sight.
2. Everyone gets buffed.
3.
...
### Issue Bingo
- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)
Contributor guide
Research direction
Start by reproducing the reported CLF order scenario with marines, following the three steps in the issue. Trace the handling of Move, Focus, and Hold orders and how faction checks are applied; done means enemy CLF orders no longer buff marines, or marine orders no longer affect CLF.
Written by the indexing model from the issue text.
Assessment
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100