cmss13-devs / cmss13-devs/cmss13

Custom Hotkey Same-Key Spam Protection Doesn't Consider Species

Open
#12,318 2 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

## Testmerges
#10999: '[DNM] Fix of various plane related issues' by Blundir at commit f85a7153c4
#11075: 'Ticket Panel (Adminhelps & Mentorhelps)' by GeneriedJenelle at commit 4ad8d0cf87
#11902: 'implement pii scrubbing for sentry' by hry-gh at commit 759efb7bd1
#12140: 'Tyrargo Rift - Various Alterations' by Steelpoint at commit 44b6e659fd
#12174: 'Yautja Armor Sets' by realforest2001 at commit ca3779b2a1
#10414: 'Port: Harm Intent uses Auto-Fire instead of PB' by MistChristmas at commit c70b0ced36
#12245: 'Xeno update icon fixes' by Drulikar at commit 431ccbee17
#12159: 'MP Main's Brig Expansion' by antlersss at commit b74a26ab24
#12316: '[EVENT][s] Combines Pathogen and Borer PRs' by realforest2001 at commit 2c5f572f0a

## Round ID
34368

## Description of the bug
As stated in the title, if you have two pick-says bound to the same key, you will not be able to use them. I assume this is for spam protection, however the protection stays even between different species. So for instance I can have a Yautja keybind on the same key as a Marine one and it won't work, even though there's no chance of spamming these keys as they are bound to different species.

## What's the difference with what should have happened?
There should be no risk of spam between keybinds for two different species.

## How do we reproduce this bug?
1) Create two picksays or three says/mes
2) Bind them to Xeno/Marine/Yautja/Synth, every bind must have a different species specification
3) Attempt to use them on any given species

## Attached logs
```
N/A
```

## Additional details
- Author: Stakeyng
- Admin: SmellyHippie
- Note: None

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.