cmss13-devs / cmss13-devs/cmss13

Not all groundside marines are notified of orbital bombardments

Open
#12,242 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

### Testmerges

[DNM] Fix of various plane related issues (#10999), Ticket Panel (Adminhelps & Mentorhelps) (#11075), implement pii scrubbing for sentry (#11902), Tyrargo Rift - Various Alterations (#12140), Yautja Armor Sets (#12174), Port: Harm Intent uses Auto-Fire instead of PB (#10414), Sensor tower fixes (#12228), Fix: Forsaken not getting their live human seeing TacMap (#12240), Combination of all active Major Map PRs [MDB Ignore] [DO NOT MERGE] (#12166)

### Round ID

_No response_

### Description of the bug

Currently, only squad marines (and intel, I believe) are notified when the orbital cannon is fired (overwatch.dm lines 1251 to 1268). The CO, XO, SOs, synthetics, etc. aren't, they just get the relative distance and direction warning from orbital_cannon.dm. **Squad marines are still notified even if they're not wearing a headset because it's innately tied to them.**

### What's the difference with what should have happened?

The orbital bombardment notification should be sent to any conscious, planetside mob wearing your faction's headset.

### How do we reproduce this bug?

1. Spawn in as a CO/XO/SO/synthetic/etc
2. Load the orbital cannon
3. Place the command tent groundside
4. Fire an OB and note the missing notification

### Issue Bingo

- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.