cmss13-devs / cmss13-devs/cmss13

MP permissions regarding Squad Distribution Computer

Open
#11,640 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

## Testmerges
#10999: 'Fix of various plane related issues' by Blundir at commit f85a7153c4
#11389: 'Yautja Leap' by realforest2001 at commit 0fd7966dd6
#11214: 'Proof of concept movielike pred invisibility' by Blundir at commit d8fc73ab73
#11459: 'admin ranks from api' by hry-gh at commit 89509ee4eb
#9774: 'Adds a minesweeper game to a bunch of interactions.' by kiVts at commit bd1bb5d5be
#11589: 'byondoidc' by hry-gh at commit d9841a3daf
#11575: 'whiteflame nerfs' by kiVts at commit 15410b2063
#9741: '[TM v0.5] Dancer Praetorian: Buffs and Changes.' by Venuska1117 at commit f0a6e9c548
#10623: '[MDB IGNORE] A.S.S - Assault, Support, Security' by Git-Nivrak at commit 019fc5e4bb
#11623: 'Kutjevo LZ1/Comms Changes + No More Medical Hellchoke' by Steelpoint at commit 5d2ad66d9f
#11634: 'DNM: additional sql logging' by hry-gh at commit c4653a91c3
#11636: 'Fix: Cades stacking on top of each other.' by MistChristmas at commit 03c79f5178

## Round ID
32180

## Description of the bug
Its possible to insert the ID into the station as the MP, but its not possible to access the screen, making ID card ejection impossible.

## What's the difference with what should have happened?
Inserting the ID and accessing the screen should be the same clearance.

## How do we reproduce this bug?
1) Man the MP position
2) Reach the SDC in the MP post by the lower medical
3) Insert the ID card into the SDC

## Attached logs
```
N/A
```

## Additional details
- Author: Zimon2210
- Admin: Tobias_reaper
- Note: The issue appears to be when you insert your ID you lose the thing that gives you the ability to access the squad comp, making ejection impossible and softlocking you until someone else ejects it for you. I suggest making ejection of the ID require no access to the computer itself

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue at the Squad Distribution Computer in the MP post with an MP ID, then trace the permission checks for screen access and ID ejection. Done means an MP can insert the ID, access the computer screen, and eject the ID without becoming softlocked.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.