cmss13-devs / cmss13-devs/cmss13

dropping items in damaged hands proc gets double called

Open
#11,087 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
DM
Stars
170
Forks
940
Avg merge
5d 16h
Merged PRs (30d)
61

Description

### Testmerges

N/A

### Round ID

N/A

### Description of the bug

when limbs get process()'d they call process_grasp(); both the ARM and the HAND both call this proc, but both are provided the HAND as an argument, this means process_grasp() (the proc that handles dropping items in a broken/damaged hand) is called twice, which skews the RNG. (2x prob(15) vs prob(15))

Image

### What's the difference with what should have happened?

The proc should be called once-- or be separated to only run twice if both the arm and the hand is broken.

### How do we reproduce this bug?

N/A

### Issue Bingo

- [x] Issue could be reproduced at least once
- [x] Issue happened in a recent (less than 7 days ago) round
- [x] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.