cms-dev / cms-dev/cms

*_has_changed logic is now useless

Open
#745 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
412
Avg merge
6d 10h
Merged PRs (30d)
3

Description

Is there any reason to keep the {whatever}_has_changed logic in the loaders? We initially added it because we wanted to support loading only a subset of the tasks in a given contest, but now we can import tasks one-by-one: it seems to me that now it may cause more issues than those it solves (ie. none).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the loaders and the {whatever}_has_changed logic referenced in the issue. Read how task imports are now performed one by one and check any nearby coverage before removing the obsolete subset-loading behavior. Done means the loaders no longer depend on this logic and individual task imports still work as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.