cms-dev / cms-dev/cms

Bug with custom checker

Open
#637 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
412
Avg merge
6d 10h
Merged PRs (30d)
3

Description

Hi there. I think I found a bug. When importing using the Polygon format, and the task uses a custom checker which is not named as check.cpp, the Polygon task loader will not find the custom checker. This seems to be fixed by checking for check.cpp in the main directory instead of in files/check.cpp, as for some reason the Polygon builder will copy the checker anyway. Modifying these two line seems to fix the issue.

https://github.com/cms-dev/cms/blob/master/cmscontrib/loaders/polygon.py#L189
https://github.com/cms-dev/cms/blob/master/cmscontrib/loaders/polygon.py#L192

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in cmscontrib/loaders/polygon.py around lines 189 and 192, where the Polygon loader looks for the custom checker. Reproduce a Polygon import using a custom checker not named check.cpp, then verify that the loader finds the checker from the main directory and completes the import successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.