Make the Worker Python process kill the actual worker thread when exiting
Open
@lw is already working on this.
Since Apr 4, 2017.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 412
- Avg merge
- 6d 10h
- Merged PRs (30d)
- 3
Description
At the moment when the Worker (i.e. the cmsWorker process) is killed (by Ctrl+C, by RS, etc.), the actual working (where compilation and evaluation happen) thread could remain alive. This needs to be fixed.
Being an ignorant in multi-thread programming in Python, I suggest to see if the daemon=True argument to Thread.__init__ is enough.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.