cms-dev / cms-dev/cms

Consider timestamps of submissions when scoring

Open
#102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
412
Avg merge
6d 10h
Merged PRs (30d)
3

Description

ScoringService currently assumes that all submissions in the database are valid and thus have to be considered when assigning scores (the same is done by RWS and AWS). This isn't necessarily always true.

At the moment the only situation I can imagine where this could be an issue is when a user gets some extra_time because he wants to appeal, submits something in this extended time-frame but then loses the appeal. The only way of effectively avoid these submissions from influencing the score is to remove them from the database: just resetting extra_time to zero won't be enough.

I think we should make all scoring-related code consider when the submission was submitted and use only the ones inside a to-be-defined "valid" time-frame. This could be difficult, in particular for RWS.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by mapping the scoring-related code, including ScoringService, RWS, and AWS, and inspect how submission timestamps and extra_time are currently handled. Define the valid time-frame before changing behavior. Done means submissions outside that frame no longer influence scores across all named scoring paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.