cmdruid / cmdruid/tapscript

Annex is ignored before signing

Open
#53 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
213
Forks
48
PR merge metrics
No merged PRs in 30d

Description

While preparing the transaction to be signed, annex extractor function expects multiple elements in the stack (such as sig + annex). This is a valid check after the tx is hashed and signed, but the same function also used while hashing the transaction before signing. This causes ignored annex before signing, causing an error when annex is included into witness later.

https://github.com/cmdruid/tapscript/blob/10459abc7d50e03c61a10c2d7b5416a36087232b/src/lib/sig/taproot/hash.ts#L207

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.