cloudwego / cloudwego/hertz

fix: replace debug fmt.Println with hlog in printNode

Open Beginner friendly
#1,525 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
7.4k
Forks
643
Avg merge
14h 5m
Merged PRs (30d)
2

Description

## Problem

\printNode()\ function in \engine.go\ uses \ mt.Println\ and \ mt.Printf\ for debug output, which writes directly to stdout instead of using hertz's logging framework (\hlog\).

## Impact

- Debug output bypasses the logging system configuration
- Cannot control log level or output destination for these messages
- Inconsistent with the rest of the codebase which uses \hlog.SystemLogger()\

## Fix

Replace \ mt.Println\/\ mt.Printf\ calls with \hlog.SystemLogger().Debugf()\ to integrate with hertz's logging framework.

Local environment limitations, relying on CI/CD automated testing.

Contributor guide

Open the contributing guide

Research direction

Open engine.go and locate printNode(), then inspect how nearby code uses hlog.SystemLogger(). Replace the debug fmt.Println and fmt.Printf output with Debugf logging, and verify through the project's CI/CD automated tests that the messages no longer write directly to stdout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.