cloudtools / cloudtools/troposphere
from_dict doesn't handle `Tags` well
Open
- Dominant language
- Python
- Stars
- 4.9k
- Forks
- 1.4k
- PR merge metrics
- No merged PRs in 30d
Description
Specifying `Tags` for an object doesn't work with `from_dict`. It isn't a subclass of `BaseAWSObject` and doesn't have a `from_dict` method.
I think we should do something like:
```
if isinstance(prop_type, Tags):
value = Tags(**value)
```
does that sound right?
Contributor guide
Research direction
Start at the from_dict entry point and the Tags class to trace how tagged values are currently converted. Reproduce the reported failure with an object containing Tags, then add coverage showing that dictionary input is converted successfully and existing from_dict behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, python
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100