cloudtools / cloudtools/troposphere

Boolean values should not be quoted in output

Open
#1,337 5 comments 12 reactions 0 assignees View on GitHub
Needs further work
Dominant language
Python
Stars
4.9k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

When outputting to YAML or JSON, boolean values should not have quotes around them. An output file will produce E3012 errors when ran through `cfn-lint` because of this. See: https://github.com/awslabs/cfn-python-lint/issues/260 for more details on why its not a warning.

Changing the `validators.boolean` function to return bool values, rather than strings would correct this issue. I can make a PR for this, but I wanted to discuss any possible repercussions first, since all these types would need to be verified.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.