cloudtools / cloudtools/nymms

nymms/config/yaml_config tests file access poorly

Open
#10 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
47
Forks
11
PR merge metrics
No merged PRs in 30d

Description

This bit of code:

```
if os.path.isfile(f):
logger.debug("Parsing include (%s:%d): %s",
filename, lineno, f)
c.extend(recursive_preprocess(f))
else:
logger.warning("%s is not a regular file, "
"skipping (%s:%d).", f, filename,
lineno)
```

Will give the error if, for example, it cannot access the file due to not having permissions to the directory the file is in. Need a better set of checks and error messages. try/open/except maybe?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.