cloudsidedev / cloudsidedev/appside

fstab

Open
#108 0 comments 0 reactions 3 assignees Claimed by @maschli View on GitHub
bug
Dominant language
Python
Stars
38
Forks
7
PR merge metrics
No merged PRs in 30d

Description

there seems to be an issue with `--tags fstab`:

we get:

```
/dev/mapper/ubuntu-vg-root / ext4 defaults 1 1
/dev/mapper/ubuntu-vg-swap_1 none swap defaults 0 0
```

should be:

```
/dev/mapper/ubuntu--vg-root / ext4 defaults 1 1
/dev/mapper/ubuntu--vg-swap_1 none swap defaults 0 0
```

the issue is probably in [this code block](https://github.com/ttssdev/appflow/blob/master/playbooks/roles/common/tasks/lvm.yml#L41-L46):

`{{ item.vg }}` which is `vg: ubuntu-vg` from:

```
conf_lvm_lvs:
- name: swap_1
vg: ubuntu-vg
```

should be `ubuntu--vg` but this could eventually break `LVM` allocation, maybe we should use `UUID` instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.