cloudposse / cloudposse/terraform-aws-eks-node-group

AL2023 userdata should include a default NodeConfig?

Open
#226 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
HCL
Stars
99
Forks
134
PR merge metrics
No merged PRs in 30d

Description

### Describe the Bug

Maybe I'm missing something from my AMI or my cluster that would make this redundant, but shouldn't the `userdata_al2023.tpl` template just include an additional block like this?
```
--//
Content-Type: application/node.eks.aws

---
apiVersion: node.eks.aws/v1alpha1
kind: NodeConfig
spec:
cluster:
name: ${cluster_name}
apiServerEndpoint: ${cluster_endpoint}
certificateAuthority: ${certificate_authority_data}
cidr: ${cluster_cider}
```

### Expected Behavior

I hoped that a NodeConfig would exist somewhere that let my AL2023 nodes join my cluster without having to define a custom `userdata_override_base64` from scratch containing the above.

### Steps to Reproduce

In a config which does set the `before_cluster_joining_userdata`, enable `ami_type = "AL2023_x86_64_STANDARD"` and a custom AL2023 based AMI, without setting that userdata. Observe nodes not reach the cluster.

### Screenshots

_No response_

### Environment

_No response_

### Additional Context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with userdata_al2023.tpl and the configuration path for before_cluster_joining_userdata, then compare the generated AL2023 user data with the NodeConfig shown in the issue. Reproduce the reported case using AL2023_x86_64_STANDARD and a custom AL2023-based AMI without userdata, and confirm that the resulting nodes can join the cluster.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, kubernetes, terraform
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.