cloudposse / cloudposse/github-action-atmos-component-updater

postgresql-user not up to date

Open
#22 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

## Describe the Bug
Submodule `modules/postgresql-user` is not updated within `aurora-postgres-resources`.
The line https://github.com/cloudposse/github-action-atmos-component-updater/blob/635735b8180db0003370950294376a864738903f/src/component_updater.py#L257 skip folders.
This could be the reason for skipping new versions for a "submodule".

## Expected Behavior
Changes in a submodule only should be detected by the updater.

## Steps to Reproduce
Steps to reproduce the behavior:
1. Configure component.yaml with version `1.310.0`
2. I expect to get version `1.330.0`
3. Updater say that no changes are detected.

## Screenshots
```
2023-10-26T10:19:11.1443389Z [26-10-2023 10:19:11] INFO Processing component: aurora-postgres-resources
2023-10-26T10:19:11.6096994Z [26-10-2023 10:19:11] INFO Looking for PR with branch: component-update/aurora-postgres-resources/1.330.0
2023-10-26T10:19:12.0148588Z [26-10-2023 10:19:12] INFO Executing 'atmos vendor pull -c aurora-postgres-resources' for component version '1.310.0' ...
2023-10-26T10:19:15.0423445Z [26-10-2023 10:19:15] INFO Successfully vendored component: aurora-postgres-resources
2023-10-26T10:19:15.0428870Z [26-10-2023 10:19:15] INFO Executing 'atmos vendor pull -c aurora-postgres-resources' for component version '1.330.0' ...
2023-10-26T10:19:18.2087857Z [26-10-2023 10:19:18] INFO Successfully vendored component: aurora-postgres-resources
2023-10-26T10:19:18.2125023Z [26-10-2023 10:19:18] INFO Looking good. No changes found
```

## Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:
- github action

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.