cloudpipe / cloudpipe/cloudpickle

Class tracking in the main process silences potential dynamic classes test failures

Open
#313 0 comments 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
Python
Stars
1.9k
Forks
195
Avg merge
1d 10h
Merged PRs (30d)
1

Description

Now that `cloudpickle` tracks dynamically created classes, `pickle_depickle(some_dynamic_class)` does not creates a new class anymore, it just returns the one already present in the main process.

As an example if we change the reproducer of #311 by using `cloudpickle.loads(cloudpickle.dumps(a))` instead of dumping a pickle in a file and loading it in a fresh python interpreter, we don't get the reported error.

Would we want to be rigorous, we would probably have to test everything involving dynamic class construction in both settings (untracked class depickled for the first time in a child process, tracked class depickled from either a warm child process or the parent process).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.