cloudpipe / cloudpipe/cloudpickle

0.8.0 3 tests fail

Open
#252 7 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Python
Stars
1.9k
Forks
195
Avg merge
1d 10h
Merged PRs (30d)
1

Description

When building cloudpickle 0.8.0 package for openSUSE I have 3 test failures:
```
[ 10s] =================================== FAILURES ===================================
[ 10s] ___________ CloudPickleFileTests.test_pickling_special_file_handles ____________
[ 10s]
[ 10s] self =
[ 10s]
[ 10s] def test_pickling_special_file_handles(self):
[ 10s] # Warning: if you want to run your tests with nose, add -s option
[ 10s] for out in sys.stdout, sys.stderr: # Regression test for SPARK-3415
[ 10s] > self.assertEqual(out, pickle.loads(cloudpickle.dumps(out)))
[ 10s] E AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb6d0> != <_pytest.capture.EncodedFile object at 0x7fc4981be990>
[ 10s]
[ 10s] tests/cloudpickle_file_test.py:98: AssertionError
[ 10s] __________________ CloudPickleTest.test_pickling_file_handles __________________
[ 10s]
[ 10s] self =
[ 10s]
[ 10s] def test_pickling_file_handles(self):
[ 10s] out1 = sys.stderr
[ 10s] out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[ 10s] > self.assertEqual(out1, out2)
[ 10s] E AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa0ef150>
[ 10s]
[ 10s] tests/cloudpickle_test.py:119: AssertionError
[ 10s] _____________ Protocol2CloudPickleTest.test_pickling_file_handles ______________
[ 10s]
[ 10s] self =
[ 10s]
[ 10s] def test_pickling_file_handles(self):
[ 10s] out1 = sys.stderr
[ 10s] out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[ 10s] > self.assertEqual(out1, out2)
[ 10s] E AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa179ed0>
[ 10s]
[ 10s] tests/cloudpickle_test.py:119: AssertionError
```

0.7.0 didn't have any issues with these tests. Full build log:
[cloudpickle.txt](https://github.com/cloudpipe/cloudpickle/files/2941345/cloudpickle.txt)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.