cloudinary / cloudinary/js-url-gen

`cloudName` required unnecessarily

Open
#588 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
55
Forks
11
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/cloudinary/js-url-gen/blob/e1b97191fff165b6ecb353acb2477cc25a062667/src/assets/CloudinaryFile.ts#L182-L193 a `cloudName` setting is explicitly required. However, in https://github.com/cloudinary/js-url-gen/blob/e1b97191fff165b6ecb353acb2477cc25a062667/src/internal/url/cloudinaryURL.ts#L20-L51 the `cloudName` isn't actually even utilized if using a `secureDistribution` and `privateCDN`.

The check for `cloudName` should be moved into `getUrlPrefix` and we should only throw when omitting the cloud name for branches where it's actually utilized.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.