cloudinary / cloudinary/cloudinary_gem

Transformation params not properly URL escaped

Open
#540 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Ruby
Stars
420
Forks
285
PR merge metrics
No merged PRs in 30d

Description

## Bug report for Cloudinary Ruby SDK
Before proceeding, please update to latest version and test if the issue persists - DONE

## Describe the bug in a sentence or two.
If the parameters passed to transformation contain a double quote, they are not properly escaped when formulating cloudinary URL, causing invalid URL to be generated

## Issue Type (Can be multiple)
- [ ] Build - Cannot install or import the SDK
- [ ] Performance - Performance issues
- [x] Behaviour - Functions are not working as expected (such as generate URL)
- [ ] Documentation - Inconsistency between the docs and behaviour
- [ ] Other (Specify)

## Steps to reproduce
Run
`Cloudinary::Utils.cloudinary_url(VIDEO_ID_HERE,{ resource_type: "video", transformation: [{color: '"abc', overlay: { font_family: "Times", font_size: 12, font_weight: "bold", text: "..." }}])`

note the '"abc' for the color

## Error screenshots or Stack Trace (if applicable)
Screenshot 2024-03-28 at 19 29 07

## Operating System
- [ ] Linux
- [ ] Windows
- [x] macOS
- [ ] All

## Environment and Libraries (fill in the version numbers)
- Cloudinary Ruby SDK version - cloudinary (1.29.0)
- Ruby Version - ruby 3.3.0
- Rails Version - Rails 7.1.3.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.