cloudhead / cloudhead/nakamoto

nakamoto-wallet: `--addresses` parameter is currently ignored

Open
#153 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
391
Forks
64
PR merge metrics
No merged PRs in 30d

Description

`nakamoto-wallet` specifies a parameter `--addresses`:

https://github.com/cloudhead/nakamoto/blob/9ea71ed71655e41b8b1ec7db02b4b8dea6f9f1ea/wallet/src/main.rs#L15-L17

But the value of that parameter is never read anywhere. In the start of wallet loop, the addresses are either fetched from the database, or if that is empty, from the hardware device:

https://github.com/cloudhead/nakamoto/blob/9ea71ed71655e41b8b1ec7db02b4b8dea6f9f1ea/wallet/src/wallet.rs#L103-L122

Happy to open a PR if someone can point me into the right direction how that parameter was intended. If it's specified, should only those addresses be watched or do we still want to load the ones from the database?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.