cloudfour / cloudfour/image-compare

Allow increasing the range input max value

Open
#73 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
144
Forks
6
Avg merge
7h 12m
Merged PRs (30d)
9

Description

Here is what I did to keep the slider working properly while increasing the range input max value:

```javascript
this.animationFrame = requestAnimationFrame(() => {
this.shadowRoot.host.style.setProperty('--exposure', `${(target.value / target.max * 100)}%`)
});
```

Setting the max value to 1000 allows to have a very smooth slide effect compared to the 100 max value.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.