cloudfour / cloudfour/SimpleSlideView

Normalizing some options now that noZepto

Open
#16 1 comment 0 reactions 1 assignee Claimed by @tylersticka View on GitHub
question
Dominant language
HTML
Stars
257
Forks
31
PR merge metrics
No merged PRs in 30d

Description

Hi @tylersticka

I'm seeing a couple of values getting computed for default options that I think are partially vestigial from Zepto. Specifically:

```
duration: ($.fx !== null) && ($.fx.cssPrefix !== null) ? $.fx.speeds._default : 400,
```

and

```
cssPrefix: ($.fx !== null) && ($.fx.cssPrefix !== null) ? $.fx.cssPrefix : '',
```

Not a lot of Google hits for `$.fx.cssPrefix` but it does appear to be Zepto-related. What are sane defaults for these now that `jQuery` is the only game in town?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.