cloudfoundry / cloudfoundry/uaa
uaa.yml - Do we have sensible defaults in our integration tests
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.6k
- Forks
- 844
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 27
Description
The PR https://github.com/cloudfoundry/uaa/pull/3689/changes was required to make the same changes into two Yaml files.
It would make sense that .../boot/uaa.yml reads all the defaults from /uaa/src/main/resources/uaa.yml and then only overrides the desired end to end configurations
All of the *MockMvcTests are facing the exact same issue. They do not inherit sensible defaults.
For example: I need to add a new url to limitedFunctionality.whitelist.endpoints
Current solution: Add entries to multiple locations (boot/uaa.yml, integration_test_properties.yml and resources/uaa.yml)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare boot/uaa.yml, integration_test_properties.yml, and src/main/resources/uaa.yml to understand which defaults are duplicated and which settings are overrides. Review the *MockMvcTests configuration as well. Done means tests inherit sensible defaults from resources/uaa.yml, so adding an endpoint such as limitedFunctionality.whitelist.endpoints requires only the intended override.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100