cloudfoundry / cloudfoundry/uaa

"GroupModifiedEvent" missing when user is automatically removed from group

Open
#2,189 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

unscheduled
Dominant language
Java
Stars
1.6k
Forks
844
Avg merge
2d 5h
Merged PRs (30d)
27

Description

What version of UAA are you running?

Version 76.5.0

How are you deploying the UAA?

We are using the BOSH release: https://github.com/cloudfoundry/uaa-release/releases/tag/v76.5.0

What did you do?

Created a new group with "zoneid: uaa". Added user with "origin: uaa" to the group. This produces a "GroupModifiedEvent" as expected. Manual removal of the user writes a "GroupModifiedEvent", too.

When the user logs in, he is automatically removed from the group (relevant coding for this should be https://github.com/cloudfoundry/uaa/blob/develop/server/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManager.java#L247-L259). We have configured an external OAuth provider. @torsten-sap can provide more details on this automatic action.

The problem for us is that the automatic removal from the group does not log a "GroupModifiedEvent". We would like to see this event for debugging and operation purposes.

What did you expect to see? What goal are you trying to achieve with the UAA?

We expected to see a "GroupModifiedEvent" as specified in https://docs.cloudfoundry.org/running/managing-cf/uaa-audit-requirements.html#scim-admin-events.

What did you see instead?

There was no "GroupModifiedEvent" logged.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in server/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManager.java around lines 247-259, where the automatic group removal is described. Compare that path with manual removal and the SCIM admin-event requirement, then verify that automatic removal produces a GroupModifiedEvent in the audit output.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.