cloudfoundry / cloudfoundry/stratos

Non-admin users should not see pod metrics

Open
#4,919 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
267
Forks
137
Avg merge
5h 14m
Merged PRs (30d)
77

Description

  • pod metrics is served from AddAdminGroupRoutes, therefore admin only
  • if the console is setup such that they have a metrics endpoint which serves metrics for a kube they're viewing.... we allow them to get to the pod metrics page
  • there they see a blank set of charts and in dev tools lots of 401's

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at AddAdminGroupRoutes and the pod metrics page mentioned in the issue, then reproduce the non-admin path while watching the browser’s network requests. Done means non-admin users cannot reach the pod metrics page and no related 401 requests or blank charts appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.