cloudfoundry / cloudfoundry/stratos
Entities that can't be favourited are shown in the home page filter by type drop down
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 267
- Forks
- 137
- Avg merge
- 5h 14m
- Merged PRs (30d)
- 77
Description
- user can only favourite endpoints, apps, orgs and spaces
- all cf entities are shown in filter though (quotas, domains, services, env vars, git commit, etc)
- need a way to define in the entity type whether it can be favourited or not
- see src/frontend/packages/core/src/shared/components/favorites-meta-card/favorite-config-mapper.ts getAllTypesForEndpoint
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/frontend/packages/core/src/shared/components/favorites-meta-card/favorite-config-mapper.ts at getAllTypesForEndpoint, then trace how entity types populate the home page filter-by-type dropdown. Identify where entity type metadata is defined and make the favouritable types distinguishable from other Cloud Foundry entities. Done means the dropdown shows only endpoints, apps, orgs and spaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100