cloudfoundry / cloudfoundry/stratos

Handle situations where fetching the service broker is forbidden

Open
#3,426 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
267
Forks
137
Avg merge
5h 14m
Merged PRs (30d)
77

Description

Sometimes a non-admin cannot fetch specific service brokers. As a general room we should not then rely on this to determine service visibility, even if there is no other way to calculate space scoped services. Therefore we should...

  • Ignore failures when fetching a service broker. I think we should still continue to attempt to fetch it, which will help us in cases where this does return and we can use it to skip the select cf/org/space step for space scoped services.
  • Ensure src/frontend/packages/core/src/shared/components/service-plan-public/service-plan-public.component.ts handles failure when fetching

General info
service plan visibility works on
.. service plan 'public' flag (green for yes)
.. if the service is space scoped (amber for yes)
.. if there are service visibilities (amber for yes)

service plan visibility shown on

  • create service instance service plan step
  • service page service plan tab

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the service-broker fetching flow and read src/frontend/packages/core/src/shared/components/service-plan-public/service-plan-public.component.ts. Verify how forbidden broker fetches affect service-plan visibility and the create-instance and service-page views. Done means fetch failures no longer block visibility decisions, while successful fetches can still support the existing selection behavior and the component handles failure safely.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
cloud, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.