cloudfoundry / cloudfoundry/stratos

Handle non-stepper api failures

Open
#2,328 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P2
Dominant language
TypeScript
Stars
267
Forks
137
Avg merge
5h 14m
Merged PRs (30d)
77

Description

  • Failures of actions outside of steppers such as start/stop app, change user role via users table pills, etc
  • 5XX errors are covered in a generic way, but won't have any context about what request failed (thinking of the case where an error is already shown
  • 4XX errors are not currently handled.
  • Need to consider that in steppers we do handle errors (both 4XX and 5XX) via the entity error I think?
  • Parent issue... #1528

Solutions?

  • Wire in 4XX error handling to internal event handling?
  • Tie in request specific errors to internal event handling?
  • Show toast on specific type of action (request failed?).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading parent issue #1528 and the existing stepper error handling, especially how entity errors are handled. Identify how non-stepper actions such as start/stop app and user-role changes report failures, then define consistent handling for 4XX and 5XX responses with request context and an appropriate user notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
api, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.