cloudfoundry / cloudfoundry/stratos

Handle cf `order-by` field

Open
#1,894 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
TypeScript
Stars
267
Forks
137
Avg merge
5h 14m
Merged PRs (30d)
77

Description

  • CF hardly ever allows sorting by more than one field, when it does it's via the param sort-by
  • Supplying this field when it's now permitted results in a 500 error (list space service instances)
  • We currently store the field to sort lists by as a query param order-direction-field
  • This gets sent in requests even though it's not a cf thing
  • Need to
    • Store the sort field used by the console separaretly to the query param
    • Ensure we don't send the order-by param for calls that don't support it

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the console's service-instance list request and the sorting state that currently stores order-direction-field. Trace how sorting parameters are added to Cloud Foundry calls, then verify the console keeps its sort field separately and unsupported calls no longer receive order-by or produce a 500 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.