cloudfoundry / cloudfoundry/node-exporter-boshrelease

Latest Monit expects a status of node_exporter_ctl start

Open
#9 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
10
Forks
10
PR merge metrics
No merged PRs in 30d

Description

I created a new Stemcell with Ubuntu 16.04 and the latest Monit Version 5.26.0.

Monit start the node_exporter_ctl and after 30 seconds by default generated a restart loop.
The problem is the "exec node_exporter" running in foreground and don't send a status back to Monit.

What is here the best practice to handle this?

I removed line 72: echo $$ > ${PIDFILE}
and added to end of exec: & echo $! >$PIDFILE

This works, but would rather use this offical Repo as source instead of forking

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the node_exporter_ctl script, especially line 72, and review how its foreground exec is managed by Monit 5.26.0 on Ubuntu 16.04. Compare the reported PID-file change with the current official BOSH release source; done means the service starts without entering a restart loop under the stated Monit configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
prometheus, shell
Domain
devops, observability-sre
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.