cloudfoundry / cloudfoundry/loggregator-agent-release
Forwarder-Agent ingress dropped metric is never incremented
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 14
- Forks
- 34
- Avg merge
- 7h 6m
- Merged PRs (30d)
- 2
Description
We have noticed that the dropped metric is never incremented and it is always zero. We were able to see that in the logs drops are being reported, but the dropped metric value never changes. Checking the code we saw that there are two diodes, one which reports the drops in the log file and another which should increment the dropped metrics, but it seems to be never called. You can find more details in the following thread on Slack.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/cmd/forwarder-agent/app/forwarder_agent.go at lines 73-77, then trace the two diodes described in the issue: the one logging drops and the one intended to increment the dropped metric. Confirm which path is not called and verify that reported drops cause the metric to increase rather than remain zero.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100