cloudfoundry / cloudfoundry/loggregator-agent-release
the retry_writer retries parsing issues for syslog messages
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 14
- Forks
- 34
- Avg merge
- 7h 6m
- Merged PRs (30d)
- 2
Description
due to the error propagation from the Writer to the retry_writer,
the call of msgs, err := w.syslogConverter.ToRFC5424(env, w.hostname)
can trigger a retry on a parsing issue, resulting in logs suggesting there where some connection issues, when the issue was indeed a parsing failure.
Retrying a parsing failure will also not resolve on retries, making the loop inefficient in this case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/pkg/egress/syslog/retry_writer.go at the retry path around the syslogConverter.ToRFC5424(env, w.hostname) call. Trace how parsing and connection errors propagate from the Writer, then verify that parsing failures are distinguished from retryable failures and are not reported as connection issues. Done means parsing failures no longer trigger ineffective retries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100