cloudfoundry / cloudfoundry/go-pubsub

deadcode in generated code

Open
#3 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

unscheduled
Dominant language
Go
Stars
57
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I was doing a bit of housekeeping and noticed this in loggregator:

deadcode: router/internal/server/v2/envelope_traverser.gen.go:20:1: hashBool is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:94:1: _Message_Envelope_Log is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:106:1: ___Message_Envelope_Log_Log is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:123:1: _Message_Envelope_Log_Log is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:146:1: _Message_Envelope_Counter is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:158:1: ___Message_Envelope_Counter_Counter is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:175:1: _Message_Envelope_Counter_Counter is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:198:1: _Message_Envelope_Gauge is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:210:1: ___Message_Envelope_Gauge_Gauge is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:227:1: _Message_Envelope_Gauge_Gauge is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:250:1: _Message_Envelope_Timer is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:262:1: ___Message_Envelope_Timer_Timer is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:279:1: _Message_Envelope_Timer_Timer is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:302:1: _Message_Envelope_Event is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:314:1: ___Message_Envelope_Event_Event is unused
deadcode: router/internal/server/v2/envelope_traverser.gen.go:330:1: _Message_Envelope_Event_Event is unused

It seems to also be in the examples:

deadcode: examples/structs/gen_struct.go:18:1: hashBool is unused
deadcode: examples/structs/gen_struct.go:97:1: _w is unused
deadcode: examples/structs/gen_struct.go:150:1: _x is unused

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting router/internal/server/v2/envelope_traverser.gen.go and examples/structs/gen_struct.go, then determine how these generated files are produced. Reproduce the reported deadcode warnings and identify whether the generated output or its source needs changing. Done means the listed unused symbols no longer trigger deadcode warnings in both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.