cloudfoundry / cloudfoundry/go-buildpack
Drop support for godep, glide, dep, and buildpack detection by vendor folder
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 85
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
Go modules, Go's official solution to dependency management, have been on by default since Go 1.16. Per the docs and the output I see when running cf push, the buildpack still contains several dependency management solutions that predate modules:
- Godep, archived on Github since 2019
- Glide, not updated since 2019
- dep, deprecated and archived since 2020
Additionally, the buildpack checks for a vendor folder, but go modules does not vendor dependencies by default; instead, it downloads dependencies go $GOPATH/pkg/mod. Vendoring is still possible, but in practice, I see few projects do it.
I propose removing the old dependency management solutions in favor of Go modules, and propose detecting the Go buildpack by checking for the presence of a go.mod file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Go buildpack's dependency-management and buildpack-detection entry points; the issue identifies vendor folders, Godep, Glide, dep, and go.mod as the relevant signals. Review the linked Cloud Foundry documentation and existing behavior before deciding the affected scope. Done means obsolete dependency detection is removed and go.mod-based detection is covered by the repository's existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100