cloudfoundry / cloudfoundry/credhub-cli

passwords starting with a dash are not supported

Open
#114 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

known issue unscheduled wontfix
Dominant language
Go
Stars
43
Forks
49
Avg merge
30m
Merged PRs (30d)
1

Description

What version of the credhub server you are using?

Server Version: 2.12.6

What version of the credhub cli you are using?

CLI Version: 2.9.3

If you were attempting to accomplish a task, what was it you were attempting to do?

set a password whose value is predetermined and starts with a dash (-)

What did you expect to happen?

password should be set

What was the actual behavior?

$ credhub set -t password -n '/example-password' -w '-supersecret'
expected argument for flag `-w, --password', but got option `-supersecret'

Please confirm where necessary:

  • I have included a log output
  • My log includes an error message
  • I have included steps for reproduction

If you are a PCF customer with an Operation Manager (PCF Ops Manager) please direct your questions to support (https://support.pivotal.io/)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the credhub set command and its -w/--password argument parsing, reproducing the reported command with a password beginning with a dash. Trace how that value is interpreted and add or update coverage for this invocation; done means the password can be set successfully without treating its value as another option.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.