cloudfoundry / cloudfoundry/cloud_controller_ng
Puma web server does not configure property request_timeout_in_seconds
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 207
- Forks
- 373
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 56
Description
Issue
Request_timeout_in_seconds is configurable on the capi-release and sets the Thin Runner request timeout. This does not appear to be set for Puma Runner
Possible Fix
Sadly, It doesn't appear as though Puma has an overall request timeout, see configuration.
One option would be to use https://github.com/zombocom/rack-timeout.
Alternatively we should make it clear in the capi-release property that it only effects Thin.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing lib/cloud_controller/runners/thin_runner.rb with lib/cloud_controller/runners/puma_runner.rb, then inspect the request_timeout_in_seconds property in the capi-release spec. Determine which supported behavior the project wants and identify the relevant tests or configuration documentation. Done means the Puma behavior is addressed or the property’s Thin-only scope is made explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100