cloudfoundry / cloudfoundry/cloud_controller_ng
Allow max-timeout for async-binding larger than 60 seconds, via "cf push command"
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 207
- Forks
- 373
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 56
Description
Hello all,
This is an enhancement request
Issue
Allow max-timeout for async-binding larger than 60 seconds, via "cf push command"
Context
The current behavior of bindings which are created on the fly via "cf push" command according to manifest file, is that in case a single binding does not succeed in 60 seconds, the push command fails.
Typically, async-bindings are used where the binding logic takes more time by default.
Therefore one can expect, than once we implemented async binding exactly due to this reason, is that it can be supported via "cf push" command, and the binding timeout can be extended beyond 60 seconds.
A reasonable approach can be to set a max-timeout on the app-deploy level (with a hard coded upper bound), and to be able to extend the push operation up to this timeout.
Steps to Reproduce
implement dummy broker which holds the request for more than 60 seconds & returns success afterwards.
state binding to this instance via manifest yaml to some hello-world app
exeucte cf push command
Expected result
push command will succeed
Current result
push command fails
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the cf push command processes manifest YAML bindings and enforces the current 60-second limit. Reproduce the delay with a dummy broker, then define and verify a configurable app-deploy timeout with an upper bound so a binding completing after 60 seconds allows the push to succeed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend, cli, cloud
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100