cloudfoundry / cloudfoundry/cloud_controller_ng

**CLI** user should NOT see a **diff** when **removing services**

Open
#2,201 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

unscheduled
Dominant language
Ruby
Stars
207
Forks
373
Avg merge
2d 12h
Merged PRs (30d)
56

Description

Context

Removing service instances from a manifest does not unbind them from the app or delete the service instance. Showing service instances removed from the manifest in the diff can confuse people into thinking the service instances will be unbound and/or deleted.


Acceptance Criteria

Omit Instance Removals

Given an app named my-app
And it is mapped to two service instances one and two
When I apply the following manifest

---
applications:
  - name: my-app
    services:
    - two

Then the service instance one should not show up as being removed in the diff


Note:

  • Pro tip for creating service instances: Try using the cf cups command (create-user-provided-service).
  • The manifest diff endpoint should not return service instance deletions, so this logic can be shared across all clients

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the manifest diff endpoint and reproduce the case with an app mapped to service instances one and two, then apply a manifest containing only two. Done means the diff omits service instance one while the issue's behavior remains limited to diff reporting, without unbinding or deleting the service instance.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.