cloudfoundry / cloudfoundry/cloud_controller_ng

cf cli always shows the default_route as being set to true when not specified in the manifest

Open
#2,198 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scheduled
Dominant language
Ruby
Stars
207
Forks
373
Avg merge
2d 12h
Merged PRs (30d)
56

Description

To reproduce:

manifest.yaml:

applications:
- name: morc2
  buildpacks:
  - go_buildpack
  env:
    GOPACKAGENAME: cora
    VAR: foobar
  processes:
  - type: web
    instances: 2

note: default_route is not specified.

Using the cf v8 cli note the default-route: true is being being added to the manifest, and set when it was not included in the manifest.

±  |develop U:2 ✗| → cf push
Pushing app morc2 to org org / space space as admin...
Applying manifest file /home/pivotal/go/src/github.com/cloudfoundry/cf-acceptance-tests/assets/pora/manifest.yml...

Updating with these attributes...
  ---
  applications:
+ - name: morc2
+   processes:
+   - instances: 2
+     type: web
    default-route: true
+   buildpacks:
+   - go_buildpack
+   env:
+     GOPACKAGENAME: cora
+     VAR: foobar
Manifest applied

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown manifest.yaml and the cf v8 CLI using cf push, then inspect how the manifest is applied and displayed. Done means a manifest that omits default_route does not gain or set default-route: true in the reported update.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.