cloudfoundry / cloudfoundry/cloud_controller_ng
Quota `apps.per_app_tasks` limits are misleading
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 207
- Forks
- 373
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 56
Description
In v3 docs, it’s mentioned apps.per_app_tasks is per app: “Maximum number of running tasks in a single application”.
However, with apps.per_app_tasks set to 1 with two different apps in same org, the first task can be executed with app1, but the second task with app2 fails with error “app_task_limit quota exceeded”. The limit is not per app but per org (or space).
It looks like we made a mistake naming/documenting that quota limit. It is number of tasks per space/org:
- https://github.com/cloudfoundry/cloud_controller_ng/blob/40ffe7bd65ffe661c45085da623b51e85bba599c/app/models/runtime/constraints/max_app_tasks_policy.rb
- https://github.com/cloudfoundry/cloud_controller_ng/blob/40ffe7bd65ffe661c45085da623b51e85bba599c/app/models/runtime/organization.rb#L244
The same problem appears on the v2 API docs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/models/runtime/constraints/max_app_tasks_policy.rb and app/models/runtime/organization.rb at the referenced revision to confirm the quota scope. Compare the v3 and v2 API documentation linked in the issue, then update the affected quota wording so both versions accurately describe the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100