cloudfoundry / cloudfoundry/cloud_controller_ng

Allow DNS top level domain in RFC 1035 check

Open
#1,556 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement unscheduled
Dominant language
Ruby
Stars
207
Forks
373
Avg merge
2d 12h
Merged PRs (30d)
56

Description

Issue

I have just used the domain name "suse" - but probably you can use any top level domain name to reproduce this issue.. So when using this top level domain name I get this error:

Using domain name "suse" causes api-group to show error "Error for shared domain name suse: name can contain multiple subdomains, each having only alphanumeric characters and hyphens of up to 63 characters, see RFC 1035."

BUT - "suse" is a valid root domain name - so I do not understand why this check blocks this and why it tells me it is against RFC - IMO a top level domain

Context

In the meantime using top level domain names internal and external is allowed and possible so we should also adjust the check, here.

Steps to Reproduce

Deploy using a top level domain name like "suse", "joedoe" or similar.

Expected result

With top level domain name I would not expect an error and the system should work.

Current result

Error message:

Using domain name "suse" causes api-group to show error "Error for shared domain name suse: name can contain multiple subdomains, each having only alphanumeric characters and hyphens of up to 63 characters, see RFC 1035."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the RFC 1035 domain-name validation used by the shared-domain API path and reproduce it with a single-label name such as "suse"; done means valid top-level names no longer trigger this error while invalid names remain rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.