cloudfoundry / cloudfoundry/cloud_controller_ng
label_selector parser is too draconian re white-space
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 207
- Forks
- 373
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 56
Description
See also https://github.com/cloudfoundry/cloud_controller_ng/issues/1443
Summing up 5 known issues:
Given this label_selector: environment in (production, staging), tier=backend
There are at least 4 known errors related to white-space handling:
- Space required before open-paren:
environment in(production, staging), tier=backend
^
- Space forbidden inside comma-separated in-block (issue #1443):
environment in (production, staging), tier=backend
^
- Space forbidden after and-type comma:
environment in (production, staging), tier=backend
^
- Spaces forbidden around equal-sign:
environment in (production, staging), tier =backend
^
- Trailing spaces forbidden
environment in (production, staging), tier=backend[SPACE]
^
- Leading spaces forbidden
[SPACE]environment in (production, staging), tier=backend
^
The examples in the Kub document appear more forgiving of white-space. They don't talk about it, at least
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the label_selector parser and compare its whitespace rules with the Kubernetes document referenced in the issue. Reproduce the six examples, then verify that leading, trailing, separator, parenthesis, and equals-sign whitespace are handled as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kubernetes, ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100