cloudfoundry / cloudfoundry/cli
Possibility to disable manifest diff.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.9k
- Forks
- 990
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 8
Description
Hi there,
after migration from v7 to v8, I've noticed introduction of manifest diff. Would be nice to have an option to disable it with an env var or so or at least prevent it's output from being passed to stdout.
https://github.com/cloudfoundry/cli/blob/fb9397c4a5db4a1ea4905ce4496e8b524794b40f/command/v7/push_command.go#L209
https://github.com/cloudfoundry/cli/blob/fb9397c4a5db4a1ea4905ce4496e8b524794b40f/command/v7/apply_manifest_command.go#L108
..some conditional skip would need to be present here.
Reasoning behind it. I know envs are not supposed to be used to treat sensitive info. However, if somebody does that, it would be nice to have an option to at least disable it from the default push output. As it wasn't present before in v7.
Best regards,
K.M.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced sections of command/v7/push_command.go and command/v7/apply_manifest_command.go, where the manifest diff is introduced and output is passed through. Trace the v7 push flow and determine how an opt-out should affect the default output; done means the manifest diff can be disabled without appearing in push output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100