cloudfoundry / cloudfoundry/cf-java-client

Disable service access not working for all cases

Open
#972 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug client triaged
Dominant language
Java
Stars
334
Forks
319
PR merge metrics
No merged PRs in 30d

Description

Hi,

I am using disable service access and encountered certain issues. Here are few combinations that are not working.

  1. When I use the following command to enable a particular service plan in a particular org cloudFoundryOperations.serviceAdmin().enableServiceAccess(EnableServiceAccessRequest .builder().serviceName("abc") .servicePlanName("qwerty") .organizationName("org") .build()).block();

and using the following command of disabling particular plan in all orgs cloudFoundryClient.servicePlans().update(UpdateServicePlanRequest .builder().publiclyVisible(false).servicePlanId("123456").build()).block();

Expected output: Plan should be disabled in all organizations
Actual Output: Plan is still enabled in "org"

  1. When I use following command to enable a service plan in all orgs cloudFoundryOperations.serviceAdmin().enableServiceAccess(EnableServiceAccessRequest .builder().serviceName("abc") .servicePlanName("qwerty") .build()).block();

and then disable particular plan in all orgs using cloudFoundryOperations.serviceAdmin().disableServiceAccess(DisableServiceAccessRequest .builder().serviceName("abc") .servicePlanName("qwerty").build()).block();

Expected output: Plan should be disabled in all organizations
Actual Output: Plan is still enabled in all organizations

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the serviceAdmin().enableServiceAccess and disableServiceAccess calls and the servicePlans().update(UpdateServicePlanRequest) call shown in the report. Reproduce both combinations, then trace how organization-specific access and publiclyVisible are handled; done means disabling the plan removes access in the reported organization and in all organizations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.