cloudfoundry / cloudfoundry/cf-deployment
Measure CF-D upgrades appropriately with uptimer
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 315
- Forks
- 315
- Avg merge
- 7d 9h
- Merged PRs (30d)
- 5
Description
CF-D pipelines currently use uptimer to capture certain measurements relating to downtime during CF-D upgrades, and to fail them when those measurements exceed certain thresholds. However, due the retry logic we've added to deploys, the thresholds are not being applied appropriately – uptimer may fail a successful deploy, then on a retry the deploy will essentially be a no-op, resulting in no downtime for uptimer to fail on because no change occurred.
### Tasks
- [ ] Reinvestigate and update the thresholds we set on upgrades.
- [x] Remove retry logic from (upgrade?) deploys to ensure that uptimer works well.
- [x] Set reasonable value for `APP_STATS_THRESHOLD` in uptimer config
- [ ] Update uptimer errors post-tear down to improve clarity
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the CF-D upgrade pipelines and their uptimer integration, including the APP_STATS_THRESHOLD setting and the deploy retry behavior. Done means upgrade thresholds are appropriate for retries and uptimer errors after teardown clearly explain the failure.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100