cloudfoundry-community / cloudfoundry-community/cf-python-client
health-check-type is ignored from manifest.yml when pushing application
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 55
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
When using the pushoperation health-check-type and related fields are ignored from a manifest file.
This is caused by the v2 api of cf using the same field names, but the dashes are converted to underscores.
The fields with dashes are dropped in _generate_application_update_request in apps.py because AppManager.APPLICATION_FIELDS does not contain them, but the underscored versions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps.py at _generate_application_update_request and inspect AppManager.APPLICATION_FIELDS, comparing the dashed health-check fields from manifest.yml with the underscored v2 API names. Done means pushing an application with these manifest fields preserves and sends their values instead of dropping them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100